Display Greek small letter mu#13668
Merged
bryevdv merged 1 commit intobokeh:branch-3.4from Jan 25, 2024
Merged
Conversation
Characters which look the same but have different underlying codes (homographs) are problematic. The abbreviation for microvolts is best represented as μV, using the 0x03bc Greek small letter mu instead of the 0x00b5 Latin Extended micro sign. This aligns with: - [The International System of Units (SI) brochure](https://www.bipm.org/documents/20126/41483022/SI-Brochure-9-EN.pdf) - NFKC normalized [Python code](https://peps.python.org/pep-3131/) and [domain names](https://unicode.org/reports/tr36/) - Section 2.5 Duplicated Characters of [Unicode Technical Report 25](https://www.unicode.org/reports/tr25/) - Bokeh's [histogram example](/bokeh/bokeh/tree/branch-3.4/examples/plotting/histogram.py#L44-L57) - Ruff confusable mapping [updates](https://github.com/astral-sh/ruff/pull/4430/files) (currently in the "preview" stage) Tested on: - Chrome, Firefox, Safari on Darwin 23.1.0 arm64 - Chrome, Edge on Windows 10 x86_64
241d755 to
7c67073
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13668 +/- ##
==============================================
- Coverage 92.59% 92.55% -0.04%
==============================================
Files 324 323 -1
Lines 20531 20529 -2
==============================================
- Hits 19010 19001 -9
- Misses 1521 1528 +7 |
Contributor
It complains about: Though that can be silenced by setting |
bryevdv
approved these changes
Jan 25, 2024
Member
|
Thanks, @covracer |
3 tasks
Chiemezuo
pushed a commit
to Chiemezuo/bokeh
that referenced
this pull request
Aug 27, 2024
Characters which look the same but have different underlying codes (homographs) are problematic. The abbreviation for microvolts is best represented as μV, using the 0x03bc Greek small letter mu instead of the 0x00b5 Latin Extended micro sign. This aligns with: - [The International System of Units (SI) brochure](https://www.bipm.org/documents/20126/41483022/SI-Brochure-9-EN.pdf) - NFKC normalized [Python code](https://peps.python.org/pep-3131/) and [domain names](https://unicode.org/reports/tr36/) - Section 2.5 Duplicated Characters of [Unicode Technical Report 25](https://www.unicode.org/reports/tr25/) - Bokeh's [histogram example](/bokeh/bokeh/tree/branch-3.4/examples/plotting/histogram.py#L44-L57) - Ruff confusable mapping [updates](https://github.com/astral-sh/ruff/pull/4430/files) (currently in the "preview" stage) Tested on: - Chrome, Firefox, Safari on Darwin 23.1.0 arm64 - Chrome, Edge on Windows 10 x86_64
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Characters which look the same but have different underlying codes (homographs) are problematic. The abbreviation for microvolts is best represented as μV, using the 0x03bc Greek small letter mu instead of the 0x00b5 Latin Extended micro sign. This aligns with:
Tested on:
Chrome, Firefox, Safari on Darwin 23.1.0 arm64
Chrome, Edge on Windows 10 x86_64
issues: fixes [BUG] Display Greek small letter mu #13667
no tests added: enabling RUF001 is probably best considered separately
release document entry: none