Remove CDSView.source and infer the source from CDSView's parent#11773
Remove CDSView.source and infer the source from CDSView's parent#11773bryevdv merged 2 commits intobranch-3.0from
CDSView.source and infer the source from CDSView's parent#11773Conversation
|
I'd have to look at it with quite a bit more care and also go back to the work I've been doing in the context of that view/filter discussion to provide any useful comments, but FWIW right now having a view for a view sounds like a step backwards - right into the uncanny valley of OOP. |
a2dd321 to
456ad6f
Compare
This has nothing to do with OOP, just the design of bokehjs (having models and views). |
|
Ah, after a more careful pass over the code I see that the two words "view" have different meaning in there. With that being said, I still can't quite say if I would've done it the same way. But seems like this change is at the very least not detrimental to the ideas in #11560 and actually is probably beneficial. |
…11773) * Remove CDSView.source and use renderer's source * Remove unnecessary type casts
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Having a
GlyphRendererand itsCDSViewuse different data sources is currently technically possible, but doesn't make sense. There is quite a bit of code making sure everything is configured correctly. All of that is unnecessary. This PR removesCDSView.sourceand adds a view forCDSViewwhich infers the source from its parent.