Handle invalid Unicode code point in the string literals#853
Merged
HalidOdat merged 4 commits intoboa-dev:masterfrom Oct 14, 2020
Merged
Handle invalid Unicode code point in the string literals#853HalidOdat merged 4 commits intoboa-dev:masterfrom
HalidOdat merged 4 commits intoboa-dev:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
==========================================
+ Coverage 59.24% 59.31% +0.07%
==========================================
Files 157 157
Lines 10037 10071 +34
==========================================
+ Hits 5946 5974 +28
- Misses 4091 4097 +6
Continue to review full report at Codecov.
|
HalidOdat
reviewed
Oct 13, 2020
HalidOdat
approved these changes
Oct 13, 2020
Razican
approved these changes
Oct 14, 2020
Member
Razican
left a comment
There was a problem hiding this comment.
Looks good to me :) at some point in the future we will need to switch to UTF-16 code-point lexing and string handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #778
It changes the following:
The lexer will no longer panic when processing the string literal with invalid Unicode code points, e.g.
"\uD83D". It will replace all the invalid code point with a fixed replacement char"�"("\uFFFD"). For example, the string"ABC\uD83D123"will become"ABC�123"after processing. The replacement is not revertable so the following example will not have the expected behavior:This issue can only be solved when we have the string data stored in bytes instead of chars.
This PR also fixes the unexpected behavior of handling hexadecimal and Unicode escape sequence, including: