[Merged by Bors] - Restructure lint lists in boa_engine#2455
Closed
[Merged by Bors] - Restructure lint lists in boa_engine#2455
boa_engine#2455Conversation
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2455 +/- ##
==========================================
+ Coverage 51.49% 51.65% +0.15%
==========================================
Files 336 337 +1
Lines 35524 35421 -103
==========================================
+ Hits 18293 18295 +2
+ Misses 17231 17126 -105
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Razican
reviewed
Nov 22, 2022
Member
Razican
left a comment
There was a problem hiding this comment.
Great work! Only halfway there with the review, and it looks promising :)
06f30bb to
20837c6
Compare
Razican
approved these changes
Nov 23, 2022
Member
Razican
left a comment
There was a problem hiding this comment.
I added a couple of suggestions, but I'm happy to merge it as-is :)
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
This Pull Request restructures the lint deny/warn/allow lists in `boa_engine`. It adds a lot of documentation to pup functions. There are still a few clippy lints that are not fixed, mainly regarding casting of number types. Fixing those lints effectiveley would in some cases probably require bigger refactors. This should probably wait for #2449 to be merged, because that PR already fixes that lints regarding the `Date` built-in.
|
Pull request successfully merged into main. Build succeeded: |
boa_engineboa_engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request restructures the lint deny/warn/allow lists in
boa_engine. It adds a lot of documentation to pup functions. There are still a few clippy lints that are not fixed, mainly regarding casting of number types. Fixing those lints effectiveley would in some cases probably require bigger refactors.This should probably wait for #2449 to be merged, because that PR already fixes that lints regarding the
Datebuilt-in.