Closed
Conversation
… checks; Also add the instruction format name in format predicates, since they're going to be used when generating encodings.
This is a map with facilities to insert a default value when the searched key has no entry yet.
The latter helps deduplicating predicates during encodings and recipes construction.
Co-authored-by: Benjamin Bouvier <public@benj.me> Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
Co-authored-by: Benjamin Bouvier <public@benj.me> Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
KILL THE SNAKE WITH FIRE.
This assert was added when porting legalization from Python to Rust and doesn't hold when we have derived type variables.
Closed
Owner
Author
|
I'll close my PR now, and will cherry-pick the 3 commits related to meta-code, so they get reviewed on the original Cranelift repo. Feel free to take over interesting content from other commits, if you'd like to, @abrown ! |
sunfishcode
pushed a commit
to bytecodealliance/cranelift
that referenced
this pull request
Jul 17, 2019
bnjbvr
pushed a commit
that referenced
this pull request
Oct 1, 2019
The x86 ISA has (at least) two encodings for PEXTRW: 1. in the SSE2 opcode (66 0f c5) the XMM operand uses r/m and the GPR operand uses reg 2. in the SSE4.1 opcode (66 0f 3a 15) the XMM operand uses reg and the GPR operand uses r/m This changes the 16-bit x86_pextr encoding from 1 to 2 to match the other PEXTR* implementations (all #2 style).
arkpar
pushed a commit
to paritytech/wasmtime
that referenced
this pull request
Mar 4, 2020
Contains fixes from @bnjbvr to codegen as a part of bnjbvr/cranelift#2; necessary for SIMD features to work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@abrown Here are my changes. I am bit surprised by the code generated to legalize splat into bitcast+pshufd in legalize-x86.rs, but it seems to work.
This is almost working! I suspect the remaining part is that we want to define an encoding for bitcast.i32x4 in the x86 meta encodings file.