feat: EVM execution opcode level optimization#77
Merged
owen-reorg merged 7 commits intobnb-chain:developfrom Apr 9, 2024
Merged
feat: EVM execution opcode level optimization#77owen-reorg merged 7 commits intobnb-chain:developfrom
owen-reorg merged 7 commits intobnb-chain:developfrom
Conversation
several optimizations included: - opcode fusion - jumpdest calculation optimization - SHA caching in interpreter Co-authored-by: redhdx <lredhdx@gmail.com>
e71fbc0 to
f315695
Compare
Collaborator
Author
|
UT test fails has been fixed. The current 2 failed cases seems not related with this PR.
FYI |
Switch interpreter jump table at runtime to avoid mismatch of optimized opcode and the spec.
owen-reorg
reviewed
Apr 2, 2024
owen-reorg
reviewed
Apr 2, 2024
owen-reorg
reviewed
Apr 2, 2024
owen-reorg
reviewed
Apr 2, 2024
owen-reorg
reviewed
Apr 2, 2024
Contributor
|
Please do refactor a little bit to avoid unnecessary changes, including format, new lines, changes with no effect, comments, etc. It will reduce potential overhead to resolve conflicts in further merge. |
ghost
reviewed
Apr 3, 2024
ghost
approved these changes
Apr 8, 2024
owen-reorg
approved these changes
Apr 9, 2024
owen-reorg
pushed a commit
to owen-reorg/op-geth
that referenced
this pull request
Apr 25, 2024
…imate implement more accurate & predicable priority fee suggestion algorithm for chains like Optimism
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
several optimizations included:
we observed ~1.2-1.5x speedup in execution time of opbnb mainnet when syncing block at hight ~11m
Description
This PR introduce several optimizations in EVM execution engine, mainly 3 points:
opcode fusion: Combine several hottest opcodes into one super instruction to reduce strength
jumpdest calculation optimizations: reduce the unnecessary jumpdest calculation every time a call happened by leverage caching.
SHA cacheing in interpreter: optimized the SHA opcode to use hash cache that already implemented in geth.
Rationale
To speed up the execution time of contracts and hence enhance the performance.
Example
N/A
Changes
Notable changes: