[R4R] fix pipecommit issue#932
Merged
unclezoro merged 2 commits intobnb-chain:developfrom Jun 13, 2022
Merged
Conversation
unclezoro
approved these changes
May 31, 2022
unclezoro
suggested changes
May 31, 2022
Contributor
unclezoro
left a comment
There was a problem hiding this comment.
It will keep as dummy root?
unclezoro
previously approved these changes
May 31, 2022
yutianwu
previously approved these changes
May 31, 2022
setunapo
reviewed
May 31, 2022
Contributor
|
Another suggestion, commit description should add more detail to tell how it is fixed, better to avoid |
Contributor
Author
sure, let me refine it. |
setunapo
previously approved these changes
Jun 1, 2022
34ac190
yutianwu
approved these changes
Jun 7, 2022
setunapo
approved these changes
Jun 7, 2022
unclezoro
approved these changes
Jun 13, 2022
qinglin89
pushed a commit
to qinglin89/bsc
that referenced
this pull request
Jun 23, 2022
This was referenced Jul 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr will fix an issue, i.e., some account root is not correctly set when committing mpt ,during pipecommit.
Rationale
During pipecommit, the account root is populated as
dummyRootand will be corrected at several places. However, the previous code will skip some accounts during correction stage. This will lead to commit error when committing mpt.This fix will correct the root for
stateOjbect, which's account root length is zero.Example
NA
Changes
Notable changes: