[R4R] fix validator pipecommit issue#877
Merged
unclezoro merged 4 commits intobnb-chain:developfrom Apr 29, 2022
Merged
Conversation
unclezoro
reviewed
Apr 28, 2022
unclezoro
previously approved these changes
Apr 28, 2022
Microcom88
previously approved these changes
Apr 28, 2022
keefel
reviewed
Apr 28, 2022
keefel
previously approved these changes
Apr 28, 2022
calmbeing
previously approved these changes
Apr 28, 2022
j75689
reviewed
Apr 28, 2022
45bc391
j75689
approved these changes
Apr 29, 2022
yutianwu
approved these changes
Apr 29, 2022
unclezoro
approved these changes
Apr 29, 2022
Microcom88
approved these changes
Apr 29, 2022
This was referenced May 2, 2022
j75689
pushed a commit
to j75689/bsc
that referenced
this pull request
Jun 15, 2022
* fix validator account root issue in piepecommit * fix test and imports * add check for snap * refacto a bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a validator runs 1.1.9 with
pipecommitenabled, sometimes it will fail to write block due to incorrect account roots, like this:This pr fix this issue by calling
CorrectAccountsRootbefore commit the block in mining.Rationale
In
pipecommit, the account roots are populated with dummy data, in the importing process the account roots are corrected, however, they are not corrected in the mining process. If the miner uses dummy roots to commit block, there will be errors.Example
Fix with this pr, validators can commit block successfully.
Changes
Notable changes: