[R4R] fix:defer bloomprocessor close#860
Merged
unclezoro merged 3 commits intobnb-chain:developfrom Apr 28, 2022
Merged
Conversation
unclezoro
approved these changes
Apr 20, 2022
pythonberg1997
approved these changes
Apr 28, 2022
keefel
approved these changes
Apr 28, 2022
This was referenced May 2, 2022
j75689
pushed a commit
to j75689/bsc
that referenced
this pull request
Jun 15, 2022
* fix:defer bloomprocessor close * fix: fix deadlock in Close * perf:rm defer bloomprocessors Close and manual close before return
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There's risk of memory leak for channel in
bloomProcessorsinProcesswhen an early return happen.Rationale
We need to ensure closing channel (
bloomProcessors.Close()) before returnExample
N/A
Changes
Notable changes:
bloomProcessors.Close()be executed beforeProcessreturnbloomProcessors.Close()for efficiency.