Skip to content

[R4R]fix pruner block tool bug, add some check logic#817

Merged
joey0612 merged 1 commit intodevelopfrom
pruner_block_tool_bug_fix
Mar 28, 2022
Merged

[R4R]fix pruner block tool bug, add some check logic#817
joey0612 merged 1 commit intodevelopfrom
pruner_block_tool_bug_fix

Conversation

@joey0612
Copy link
Copy Markdown
Contributor

Description

fix prune-block-tool bugs

Rationale

fix bugs:

  1. When the prune-block-tool is executed, "Failed to decode block body" error may be reported due to txloopuplimit setting.
  2. Added some verification logic, because some data related to the block may be deleted after the prune-block-tool is executed.
  3. Force the input of ‘--datadir.ancient’ to be an absolute path. Many users always fail to execute because they are caught in the splicing of relative paths of ‘--datadir’ and ‘--datadir.ancient’

@unclezoro unclezoro changed the title fix pruner block tool bug, add some check logic [R4R]fix pruner block tool bug, add some check logic Mar 28, 2022
@flywukong flywukong self-requested a review March 28, 2022 05:02
@flywukong
Copy link
Copy Markdown
Contributor

LGTM

@joey0612 joey0612 merged commit 4ed99ca into develop Mar 28, 2022
Copy link
Copy Markdown

@richardrich975 richardrich975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joey0612 joey0612 deleted the pruner_block_tool_bug_fix branch March 30, 2022 03:13
jsvisa added a commit to jsvisa/bor that referenced this pull request Mar 17, 2023
Signed-off-by: Delweng <delweng@gmail.com>
jsvisa added a commit to jsvisa/bor that referenced this pull request Jun 28, 2023
Signed-off-by: Delweng <delweng@gmail.com>
manav2401 pushed a commit to 0xPolygon/bor that referenced this pull request Apr 9, 2024
Signed-off-by: Delweng <delweng@gmail.com>
manav2401 added a commit to 0xPolygon/bor that referenced this pull request May 9, 2024
* core/state: typo

Signed-off-by: Delweng <delweng@gmail.com>

* core/rawdb: backport from bnb-chain/bsc#543

Signed-off-by: Delweng <delweng@gmail.com>

* eth,ethdb,node,core/state: backport from bnb-chain/bsc#543

Signed-off-by: Delweng <delweng@gmail.com>

* eth,core: backport from bnb-chain/bsc#543

Signed-off-by: Delweng <delweng@gmail.com>

* cmd: open db with freeze disabled

Signed-off-by: Delweng <delweng@gmail.com>

* cli: snapshot prune-block

Signed-off-by: Delweng <delweng@gmail.com>

* fix typo

Signed-off-by: Delweng <delweng@gmail.com>

* cli/snapshot: fix the issue of dup open db error

Signed-off-by: Delweng <delweng@gmail.com>

* cli/snapshot: resolve datadir and ancient before backup

Signed-off-by: Delweng <delweng@gmail.com>

* core: more prune-block log

Signed-off-by: Delweng <delweng@gmail.com>

* core: truncatetail missing f.offset

Signed-off-by: Delweng <delweng@gmail.com>

* core/rawdb: indextx adjust offset of pruned block

Signed-off-by: Delweng <delweng@gmail.com>

* core/rawdb: freezer batch should implement the offset commit, ref bnb-chain/bsc#1005

Signed-off-by: Delweng <delweng@gmail.com>

* core: check of ancientdb, backport bnb-chain/bsc#817

Signed-off-by: Delweng <delweng@gmail.com>

* core/state: read raw borReceipt to backup

Signed-off-by: Delweng <delweng@gmail.com>

* core/rawdb: bor receipt maybe in []Receipt or Receipt RLP format

Signed-off-by: Delweng <delweng@gmail.com>

* core/state: typo and error msg

Signed-off-by: Delweng <delweng@gmail.com>

* core/rawdb: offSet -> offset

Signed-off-by: Delweng <delweng@gmail.com>

* cli/snapshot: comment

Signed-off-by: Delweng <delweng@gmail.com>

* cli/snapshot: add prune-block doc

Signed-off-by: Delweng <delweng@gmail.com>

* docs: add prune-block document

Signed-off-by: Delweng <delweng@gmail.com>

* core/rawdb: print wrong bor-receipt length

Signed-off-by: Delweng <delweng@gmail.com>

* internal/cli: add snapshot prune block tests (referenced from bsc's PR)

* improve errors

* cmd, core, eth, internal: fix lint

* internal/cli: refactor snapshot prune block test

* fix linters in tests

* internal/cli: add inspect-ancient-db command, update docs

* pruner: use a generic function for simplification

* internal/cli: fixes for inspect-db command

* internal/cli: improve pruning tests

* core/rawdb: update end block calculation logic in inspect command

* core/rawdb: improve checks db initialisation

* core/rawdb: remove offset check

* update mocks for span, ethdb and add command in makefile

* docs/cli: update docs with inspect command

* go mod tidy

* refactor and resolve conflicts

* resolve more conflicts

* refactor

* explicitly read node for hash scheme

* add check for hash scheme, fix tests

* fix typo

* update docs and add warning

* raise error if pbss is enabled

* revert read raw bor receipt change

* consensus/bor: handle nil header case in get root hash

* address comments

* core/rawdb: check chain continuity by matching parent hash

* core/rawdb: account for pruned ancient blocks

* go mod tidy

* fix tests

* fix tests

---------

Signed-off-by: Delweng <delweng@gmail.com>
Co-authored-by: Delweng <delweng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants