[R4R]fix code of difflayer not assgin before return#808
Merged
unclezoro merged 1 commit intobnb-chain:developfrom Mar 28, 2022
Merged
[R4R]fix code of difflayer not assgin before return#808unclezoro merged 1 commit intobnb-chain:developfrom
unclezoro merged 1 commit intobnb-chain:developfrom
Conversation
yutianwu
approved these changes
Mar 23, 2022
j75689
approved these changes
Mar 28, 2022
unclezoro
added a commit
that referenced
this pull request
Mar 29, 2022
This was referenced Apr 8, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugfix for diff layer may have nil code even there is a new smart contract created in the block.
Rationale
The bug is introduced in pipecommit PR.
When doing
CommitofStateDB, the difflayer is returned while thecommmitTrieroutine may assign the code of difflayer in the future.This bug will impact the diff sync: difflayer may not contains the all changed codes.
Example
No
Changes
After this patch, the node can always get the same difflayers.