[R4R]fix race condition on preimage#797
Merged
unclezoro merged 2 commits intobnb-chain:developfrom Mar 28, 2022
Merged
Conversation
[R4R] Release v1.1.8
yutianwu
approved these changes
Mar 25, 2022
j75689
approved these changes
Mar 28, 2022
unclezoro
added a commit
that referenced
this pull request
Mar 29, 2022
This was referenced Apr 8, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We introduce the race condition on
preimagewhen we implement the pipe commit feature.refer to #757
Rationale
Fix the race condition on
preimage:It can be fixed read lock the db when we flush preimage into storaage.
Example
No API changes
Changes
NO