miner: discard outdated bids before simulation#3121
Merged
zzzckck merged 1 commit intobnb-chain:developfrom May 28, 2025
buddh0:discard-outdated-bids-before-simulating
Merged
miner: discard outdated bids before simulation#3121zzzckck merged 1 commit intobnb-chain:developfrom buddh0:discard-outdated-bids-before-simulating
zzzckck merged 1 commit intobnb-chain:developfrom
buddh0:discard-outdated-bids-before-simulating
Conversation
zzzckck
approved these changes
May 28, 2025
galaio
approved these changes
May 28, 2025
This was referenced May 28, 2025
Merged
sysvm
pushed a commit
to sysvm/bsc
that referenced
this pull request
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
miner: discard outdated bids before simulation
Rationale
there may be many outdated bids in channel newBidCh
they may be cleared when simulating, cause panic, just filter out them before simulating.
Example
add an example CLI or API response...
Changes
Notable changes: