bsc2: fix block sidecar fetching issue;#3087
Merged
zzzckck merged 6 commits intobnb-chain:developfrom May 14, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a block sidecar fetching issue by modifying how sidecars are queried and passed to block data constructors, ensuring that sidecars are actively retrieved during block processing. Key changes include updating the NewBlockData function signature, modifying block fetching in the bsc handler to query sidecars explicitly, and adding sidecar sanity checks in the main handler.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eth/protocols/bsc/protocol.go | Updated NewBlockData to accept externally fetched sidecars. |
| eth/protocols/bsc/handler.go | Modified block range handling to fetch sidecars for each block. |
| eth/handler.go | Added sanity check for sidecars to prevent wrong block messages. |
NathanBSC
reviewed
May 14, 2025
NathanBSC
reviewed
May 14, 2025
Contributor
|
|
buddh0
approved these changes
May 14, 2025
zzzckck
approved these changes
May 14, 2025
This was referenced May 16, 2025
Merged
galaio
added a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
galaio
added a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the problem that BlockByRange occasionally does not return the sidecar of the block normally. By actively querying the sidecar again, the block cache is lost and the sidecar exception is avoided.
Changes
Notable changes: