miner: reset recommit timer on new block#3081
Merged
zzzckck merged 1 commit intobnb-chain:developfrom May 12, 2025
Merged
Conversation
galaio
approved these changes
May 12, 2025
zlacfzy
approved these changes
May 12, 2025
buddh0
approved these changes
May 12, 2025
This was referenced May 16, 2025
Merged
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For historical reasons,
the reset timerwas added to fix a corner case issue, that the chain could be stuck.The recommit code was kept, mainly because it has no obvious side-effect and the corner could is still there?(Personally, I prefer to keep right now, but also ok to remove it in the future.)
But it should be reseted on new block, this PT just do it.
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: