Skip to content

Revert "config: apply default value for Eth.Miner option in config.to…#3024

Merged
zzzckck merged 1 commit intobnb-chain:developfrom
zzzckck:config_default_value_gen_revert
Apr 14, 2025
Merged

Revert "config: apply default value for Eth.Miner option in config.to…#3024
zzzckck merged 1 commit intobnb-chain:developfrom
zzzckck:config_default_value_gen_revert

Conversation

@zzzckck
Copy link
Copy Markdown
Collaborator

@zzzckck zzzckck commented Apr 14, 2025

Description

This reverts commit 84feb02 in PR #3022
As it actually does not work, since the gentool: https://github.com/fjl/gencodec does not support recursive elements.

Rationale

NA

Example

NA

Changes

NA

@zzzckck zzzckck merged commit 365b0af into bnb-chain:develop Apr 14, 2025
7 checks passed
@zzzckck zzzckck deleted the config_default_value_gen_revert branch April 14, 2025 13:55
forcodedancing pushed a commit to forcodedancing/bsc that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants