go.mod: update missing dependency#2546
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Jun 28, 2024
Merged
Conversation
repo github.com/wercker/journalhook no longer has the commit: 5d0a5ae867b3, the commit has been deleted actually journalhook was imported indirectly by prsym, and it is not used in BSC. the latest prysm also removed the dependency of journalhook. just replace it with the latest commit should be fine.
yutianwu
approved these changes
Jun 27, 2024
buddh0
approved these changes
Jun 28, 2024
zlacfzy
approved these changes
Jun 28, 2024
zzzckck
added a commit
to zzzckck/bsc
that referenced
this pull request
Jul 1, 2024
This was referenced Jul 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
to fix: #2544
github.com/wercker/journalhook@v0.0.0-20180428041537-5d0a5ae867b3was imported indirectly bygithub.com/prysmaticlabs/prysm@v0.0.0-20220124113610-e26cde5e091b.but the
commit: 5d0a5ae867b3was deleted, so the compile would failed for the first time.Actually journalhook is not used in BSC, the latest prysm also removed the dependency of journalhook.
Just replace it with the latest commit should be fine.
Rationale
NA
Example
NA
Changes
NA