Conversation
note: blobGasFeePrice can not be zero right now.
this case failed randomly in github CI, the ratio of around 20% but can not be reproduced locally by: ``` go test -p 1 -v -run TestSnapSyncWithBlobs -count 100 ``` there could be a potential risk between `runEthPeer` and `runSnapExtension`,as they shared the same handler.peers. Add extra wait time for `runEthPeer` to resolve it. And same for another UT: testBroadcastBlock
buddh0
approved these changes
Jun 21, 2024
galaio
approved these changes
Jun 21, 2024
unclezoro
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notice:
v1.4.10 solved the "BAD BLOCK" issue after Haber hard fork, pls use this version if your node has the BAD BLOCK issue.
Description
v1.4.10 is a maintenance release, which has several improvements and fixes:
There is no compatible change, to upgrade to v1.4.10 from v1.4.x, simply replace the binary should work.
Change Log
FEATURE
IMPROVEMENT
BUGFIX
Example
NA
Compatibility
NA