fix: ensure empty withdrawals after cancun before broadcast#2525
Merged
zzzckck merged 1 commit intobnb-chain:developfrom Jun 21, 2024
Merged
Conversation
232a60e to
c65c83e
Compare
zlacfzy
approved these changes
Jun 21, 2024
galaio
approved these changes
Jun 21, 2024
unclezoro
suggested changes
Jun 21, 2024
Contributor
unclezoro
left a comment
There was a problem hiding this comment.
Do you think it is necessary to change the code of downloader too?
Contributor
Author
It's not necessary IMO
|
zzzckck
approved these changes
Jun 21, 2024
unclezoro
approved these changes
Jun 21, 2024
This was referenced Jun 21, 2024
Merged
jellyb0y
pushed a commit
to jellyb0y/bsc
that referenced
this pull request
Aug 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: ensure empty withdrawals after cancun before broadcast
Rationale
no matter get a new block directly or by fetching
both need to ensure empty withdrawals after cancun before broadcast
Example
add an example CLI or API response...
Changes
Notable changes: