eth/handler: check blobs before broadcast blocks#2450
Merged
zzzckck merged 1 commit intobnb-chain:developfrom May 13, 2024
Merged
eth/handler: check blobs before broadcast blocks#2450zzzckck merged 1 commit intobnb-chain:developfrom
zzzckck merged 1 commit intobnb-chain:developfrom
Conversation
4a446e8 to
2d2a255
Compare
zzzckck
reviewed
May 13, 2024
| broadcastBlockWithCheck := func(block *types.Block, propagate bool) { | ||
| // All the block fetcher activities should be disabled | ||
| // after the transition. Print the warning log. | ||
| if h.merger.PoSFinalized() { |
Collaborator
There was a problem hiding this comment.
Maybe we can remove this check? not needed for BSC.
zzzckck
reviewed
May 13, 2024
| // the chain has finished the transition or not, the PoS headers | ||
| // should only come from the trusted consensus layer instead of | ||
| // p2p network. | ||
| if beacon, ok := h.chain.Engine().(*beacon.Beacon); ok { |
zzzckck
approved these changes
May 13, 2024
galaio
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
eth/handler: check blobs before broadcast blocks
Rationale
when nodes get a new block from other peers,
It will broadcast blocks directly to part peers after only
verifyHeaderhere add a more check before broadcasting.
Example
add an example CLI or API response...
Changes
Notable changes: