all: use errors.New() when there is no param rather than fmt.Errorf()#2247
Merged
zzzckck merged 9 commits intobnb-chain:developfrom Mar 11, 2024
yasyzb:fix-fmt-errorf
Merged
all: use errors.New() when there is no param rather than fmt.Errorf()#2247zzzckck merged 9 commits intobnb-chain:developfrom yasyzb:fix-fmt-errorf
zzzckck merged 9 commits intobnb-chain:developfrom
yasyzb:fix-fmt-errorf
Conversation
release: draft release v1.3.5
draft release v1.3.6
draft release v1.3.7
draft release v1.3.8
draft release v1.3.9
draft release v1.3.10
zzzckck
approved these changes
Mar 11, 2024
zlacfzy
approved these changes
Mar 11, 2024
Collaborator
|
thx |
abicky
added a commit
to abicky/bsc
that referenced
this pull request
May 11, 2025
This file appears to have been unintentionally added in bnb-chain#2247.
abicky
added a commit
to abicky/bsc
that referenced
this pull request
May 12, 2025
This file appears to have been unintentionally added in bnb-chain#2247.
abicky
added a commit
to abicky/bsc
that referenced
this pull request
May 12, 2025
This file appears to have been unintentionally added in bnb-chain#2247.
alex-10072
pushed a commit
that referenced
this pull request
May 12, 2025
This file appears to have been unintentionally added in #2247.
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
This file appears to have been unintentionally added in bnb-chain#2247.
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
May 29, 2025
This file appears to have been unintentionally added in bnb-chain#2247.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are many fmt.Errorf() with no param.
Rationale
Parameterless errors should be using errors.New instead of fmt.Errorf.
Example
Changes
Notable changes: