Merged
Conversation
MatusKysel
approved these changes
Jan 8, 2024
weiihann
added a commit
to weiihann/bsc
that referenced
this pull request
Jan 10, 2024
* p2p/discover: only show discovery status for bootnodes * eth/downloader: uplevel expired request log
sysvm
pushed a commit
to sysvm/bsc
that referenced
this pull request
Jan 22, 2024
* p2p/discover: only show discovery status for bootnodes * eth/downloader: uplevel expired request log
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves user experience by modifying logs output, mainly on:
Current statusfor regular nodes, only used for bootnodesExpired request does not existfromErrortoTraceRationale
For the 1st log change,
Current statuslog is meant for bootnodes to monitor the discovery status. For regular nodes, the information is not useful.For the 2nd log change, when
*queue.Revoke()and*queue.expire()happen concurrently, the resulting pending pool will no longer contain the peer request. Hence,Expired request does not existwill be shown. It's not a useful log for an average user, so its log level can be changed toTrace.