Skip to content

fix: fix pebble mem table size boundary error#2120

Merged
zzzckck merged 1 commit intobnb-chain:developfrom
flywukong:fix-pebble
Jan 3, 2024
Merged

fix: fix pebble mem table size boundary error#2120
zzzckck merged 1 commit intobnb-chain:developfrom
flywukong:fix-pebble

Conversation

@flywukong
Copy link
Copy Markdown
Contributor

Description

If mem table size exceeds 4G, the memtable will be set to 4G in bsc code . But Pebble has not handled this boundary well , it require less than 4G but not equal 4G . (cockroachdb/pebble#3008)

Rationale

solve issue(#2091)

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@flywukong flywukong changed the title fix: fix pebble boundary erroe fix: fix pebble boundary error Dec 28, 2023
@flywukong flywukong changed the title fix: fix pebble boundary error fix: fix pebble mem table size boundary error Dec 28, 2023
Copy link
Copy Markdown
Contributor

@fynnss fynnss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzckck zzzckck merged commit a25a214 into bnb-chain:develop Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants