Fix cornercase in capping memory allowance#3008
Open
rjl493456442 wants to merge 2 commits intocockroachdb:masterfrom
Open
Fix cornercase in capping memory allowance#3008rjl493456442 wants to merge 2 commits intocockroachdb:masterfrom
rjl493456442 wants to merge 2 commits intocockroachdb:masterfrom
Conversation
This pull request addresses a corner case when capping the pebble memory allowance. On a 32-bit machine, the memory usage is capped at MaxInt32 (note that this value is also inclusive), and on a 64-bit machine, it's capped at MaxUint32. These edge values should also be considered valid options.
Member
|
This change is |
|
@jbowens Gentle ping if this is something that would go into the 23.2 release as a fix? We hit an issue in our code when setting the cap to exactly MaxUint32. Also, the same issue applied to batch sizes. Perhaps that should also be allowed to reach the maxBatchSize constant? |
|
Based on the comments for the two constants, it would seem that the max is inclusive as @rjl493456442 said. If it's exclusive, perhaps the comment / naming should be clarified a bit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a corner case when capping the pebble memory allowance. On a 32-bit machine, the memory usage is capped at MaxInt32 (note that this value is also inclusive), and on a 64-bit machine, it's capped at MaxUint32. These edge values should also be considered valid options.