consensus/parlia: hardfork block can be epoch block#1964
Merged
brilliant-lx merged 1 commit intobnb-chain:developfrom Nov 14, 2023
buddh0:hardfork_block_can_be_epoch_block
Merged
consensus/parlia: hardfork block can be epoch block#1964brilliant-lx merged 1 commit intobnb-chain:developfrom buddh0:hardfork_block_can_be_epoch_block
brilliant-lx merged 1 commit intobnb-chain:developfrom
buddh0:hardfork_block_can_be_epoch_block
Conversation
pythonberg1997
approved these changes
Nov 3, 2023
weiihann
pushed a commit
to weiihann/bsc
that referenced
this pull request
Dec 5, 2023
This was referenced Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
consensus/parlia: hardfork block can be epoch block
Rationale
shanghai hardfork will be enabled based on block time instead of block number
but hardfork block can't be epoch block when enable luban
this patch find the reason , fix it and remove the warning in comments
so no fear of shanghai hardfork time run into epoch block
Example
add an example CLI or API response...
Changes
Notable changes: