code: remove accountTrieCache and storageTrieCache#1949
Merged
brilliant-lx merged 2 commits intobnb-chain:developfrom Oct 30, 2023
Merged
code: remove accountTrieCache and storageTrieCache#1949brilliant-lx merged 2 commits intobnb-chain:developfrom
brilliant-lx merged 2 commits intobnb-chain:developfrom
Conversation
accountTrieCache and storageTrieCache were introduced in this PR: bnb-chain#257, which is to improve performance. Actually the performance gain is quite limitted, as there is already dirty and clean cache for trie node. And after big merge, these 2 cache can not be used when PBSS is enabled. So remove these code to simplify the logic.
buddh0
reviewed
Oct 27, 2023
buddh0
approved these changes
Oct 27, 2023
zlacfzy
approved these changes
Oct 30, 2023
Contributor
|
revert trie commited flag in other PR ？ |
joey0612
approved these changes
Oct 30, 2023
2 tasks
Merged
whw188
pushed a commit
to tylerteea/mev-bsc
that referenced
this pull request
Dec 6, 2023
accountTrieCache and storageTrieCache were introduced in this PR: bnb-chain#257, which is to improve performance. Actually the performance gain is quite limited, as there is already dirty and clean cache for trie node. And after big merge, these 2 cache can not be used when PBSS is enabled. So remove these code to simplify the logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
accountTrieCache and storageTrieCache were introduced in this PR: #257, which is to improve performance. Actually the performance gain is quite limitted, as there is already dirty and clean cache for trie node.
And after big merge, these 2 cache can not be used when PBSS is enabled. So remove these code to simplify the logic.
Rationale
NA
Example
NA
Changes
NA