Skip to content

Add BEP1&2 proposals#1

Merged
darren-liu merged 2 commits intomasterfrom
token_proposal
Apr 12, 2019
Merged

Add BEP1&2 proposals#1
darren-liu merged 2 commits intomasterfrom
token_proposal

Conversation

@chainwhisper
Copy link
Copy Markdown
Contributor

In this PR, BEP 1&2 were added.
BEP1 is the general guideline and BEP2 is about tokens on Binance Chain.

@darren-liu darren-liu merged commit 5468ef3 into master Apr 12, 2019
@chainwhisper chainwhisper deleted the token_proposal branch April 12, 2019 12:17
@wjmelements
Copy link
Copy Markdown
Contributor

wjmelements commented Apr 30, 2019

Why does BEP2 use signed integers for amount and supply?

| :------------ | :-------- | :------------------------------------------------------------ |
| Name | string | Name of the newly issued asset, limited to 32 unicode characters, e.g. "ABCcoin" |
| Symbol | string | The length of the string for representing this asset is between 3 and 8 alphanumeric characters and is case insensitive. ".B" suffixed symbol is also allowed for pegging to those tokens already exist on other chains. The symbol is suffixed with the first 3 bytes of the issue transaction hash to remove a constraint of requiring unique token names. The native token, BNB, does not require this suffix. |
| Total Supply | int64 | The total supply for this token can have a maximum of 8 digits of decimal and is boosted by 1e8 in order to store as int64. The amount before boosting should not exceed 90 billion. |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there an artificial supply cap?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the cap is similar to the amount possible when subdividing by 1e8. The real limit is ~92.23372 Billion.

@wjmelements
Copy link
Copy Markdown
Contributor

You should probably increase the number of bits to 128 or 256 from 63.

@wjmelements
Copy link
Copy Markdown
Contributor

wjmelements commented Apr 30, 2019

The supply constraint is crippling. Tether could not fit on Binance chain today without issuing multiple tokens because the limit is $900 Million. You may think it is currently $90 Billion, but because burns must be processed in fixed units of 1e8, the actual token must represent the smallest denomination of currency. For the dollar this is one cent: $0.01. So, less than one-third of Tether's supply can fit on Binance Chain.

Edit: I'm now confident I misunderstood the 1e8 modifier; it seemed to be the modulo for mints and redemptions. The limit is 100x higher than previously asserted, but still far too low.

@wjmelements
Copy link
Copy Markdown
Contributor

#4

cryptom-dev pushed a commit that referenced this pull request Jun 24, 2020
bnb-tw pushed a commit that referenced this pull request Jan 24, 2023
Update BEP-174 with newer function changes
Copy link
Copy Markdown

@jonesk7734 jonesk7734 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants