Merged
Conversation
CodSpeed Performance ReportMerging #3242 will not alter performanceComparing Summary
|
5c40743 to
cbf000b
Compare
mattsse
approved these changes
Dec 19, 2025
mattsse
reviewed
Dec 19, 2025
crates/database/src/states/cache.rs
Outdated
| pub fn apply_evm_state<F>( | ||
| &mut self, | ||
| evm_state: impl IntoIterator<Item = (Address, Account)>, | ||
| pub fn apply_evm_state<'a, F, T>( |
Collaborator
There was a problem hiding this comment.
not sure if this is necessary, but perhaps we should mark this as must_use
rakita
requested changes
Dec 22, 2025
Member
rakita
left a comment
There was a problem hiding this comment.
Not collecting the Iterator is a footgun that would not apply the change to the state if not collected. So would leave it as is, of course, open to some other solutions.
Collaborator
Author
|
moved this to a separate |
rakita
reviewed
Dec 22, 2025
| }); | ||
| if let Some(s) = self.transition_state.as_mut() { | ||
| s.add_transitions(transitions) | ||
| } |
Member
There was a problem hiding this comment.
You need here else { transitions.collect::<Vec<_>>()}
Member
There was a problem hiding this comment.
This is why it is a footgun, very hard to catch :)
rakita
approved these changes
Dec 22, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we can avoid a collect here