Conversation
CodSpeed Performance ReportMerging #3163 will not alter performanceComparing Summary
|
zerosnacks
approved these changes
Nov 12, 2025
Collaborator
zerosnacks
left a comment
There was a problem hiding this comment.
Makes sense!
For reference: https://github.com/foundry-rs/foundry/blob/ac00e0bb33fcc72f2554a41564cff659c2a8c90b/crates/evm/core/src/backend/mod.rs#L1454-L1455 shows post-refactor commit but indeed https://github.com/foundry-rs/foundry/blob/ac00e0bb33fcc72f2554a41564cff659c2a8c90b/crates/evm/core/src/backend/mod.rs#L1435-L1436 API is desired
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foundry requires this in https://github.com/foundry-rs/foundry/blob/806792b21fd5ae9b9d2480b37a8a616ad09b544e/crates/evm/core/src/backend/mod.rs#L1457
Have added both
set_nonceandunsafe_set_nonce, set_nonce would create entry an touch the account,while unsafe_set_nonce would skip those steps and would just change the nonce number.