Skip to content

fix(op): Ensure L1Block account is always loaded#3150

Merged
rakita merged 3 commits intorelease/v97from
rakita/always-load-l1block-acc
Nov 7, 2025
Merged

fix(op): Ensure L1Block account is always loaded#3150
rakita merged 3 commits intorelease/v97from
rakita/always-load-l1block-acc

Conversation

@rakita
Copy link
Copy Markdown
Member

@rakita rakita commented Nov 7, 2025

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 7, 2025

CodSpeed Performance Report

Merging #3150 will not alter performance

Comparing rakita/always-load-l1block-acc (27c3949) with main (5d02c78)1

Summary

✅ 173 untouched

Footnotes

  1. No successful run was found on release/v97 (c0ef857) during the generation of this report, so main (5d02c78) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@klkvr
Copy link
Copy Markdown
Collaborator

klkvr commented Nov 7, 2025

should we fix this in State<DB> maybe?

Copy link
Copy Markdown
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

@klkvr I'd also like to do this yes

Copy link
Copy Markdown
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a quick op legacy tx execute pre for regolith?

just to make ensure this is working

}
self.load_cache_account(address)?;
// safe to unwrap as account is loaded a line above.
self.cache.accounts.get_mut(&address).unwrap()
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

@rakita rakita merged commit bb04627 into release/v97 Nov 7, 2025
27 checks passed
rakita added a commit that referenced this pull request Nov 10, 2025
* fix(op): Ensure L1Block account is always loaded

* dont panic on State::storage fn

* add test for pre regolit tx
rakita added a commit that referenced this pull request Nov 10, 2025
* fix(op): Ensure L1Block account is always loaded

* dont panic on State::storage fn

* add test for pre regolit tx
@github-actions github-actions bot mentioned this pull request Nov 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 21, 2026
bluealloy/revm#3154)

* fix(op): Ensure L1Block account is always loaded

* dont panic on State::storage fn

* add test for pre regolit tx
@rakita rakita deleted the rakita/always-load-l1block-acc branch February 16, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants