Merged
Conversation
CodSpeed Performance ReportMerging #3116 will not alter performanceComparing Summary
|
1 task
borngraced
reviewed
Oct 20, 2025
mattsse
reviewed
Oct 21, 2025
Collaborator
mattsse
left a comment
There was a problem hiding this comment.
i think this all checks out but dont feel equipped to properly review this
rakita
commented
Oct 21, 2025
Member
Author
|
There are a lot of eest tests that cover access list, so I am confident that this is correct |
mattsse
approved these changes
Oct 21, 2025
| self.warm_account_and_storage(address, []) | ||
| } | ||
| /// Sets access list inside journal. | ||
| fn warm_access_list(&mut self, access_list: HashMap<Address, HashSet<StorageKey>>); |
Collaborator
There was a problem hiding this comment.
this seems fine, given that this more or less just internal api
klkvr
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't load access list immediately at the start. Push the access list in the journal and on load mark accounts/storages warm.