Skip to content

chore: remove redundant alloy-eip7702 from handler dev-dependencies#3105

Merged
rakita merged 4 commits intobluealloy:mainfrom
RyanBGG:chore
Oct 18, 2025
Merged

chore: remove redundant alloy-eip7702 from handler dev-dependencies#3105
rakita merged 4 commits intobluealloy:mainfrom
RyanBGG:chore

Conversation

@RyanBGG
Copy link
Copy Markdown
Contributor

@RyanBGG RyanBGG commented Oct 15, 2025

alloy-eip7702 is already available as a transitive dependency through context-interface, making the dev-dependency declaration redundant.

Additionally, referencing features of dev-dependencies in the std and serde features is not a recommended practice.

@rakita
Copy link
Copy Markdown
Member

rakita commented Oct 17, 2025

@RyanBGG this needs some cleanup

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 17, 2025

CodSpeed Performance Report

Merging #3105 will not alter performance

Comparing RyanBGG:chore (1ade226) with main (ca7a08b)

Summary

✅ 173 untouched

@RyanBGG
Copy link
Copy Markdown
Contributor Author

RyanBGG commented Oct 17, 2025

@rakita all good now.

Copy link
Copy Markdown
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there now a database dependency in context and handler and inspector?

@RyanBGG
Copy link
Copy Markdown
Contributor Author

RyanBGG commented Oct 18, 2025

@rakita sorry for the confusing.

Second commit incorrectly removed database/std and database/serde revert now

@RyanBGG RyanBGG requested a review from rakita October 18, 2025 13:26
@rakita rakita merged commit ee8c7dc into bluealloy:main Oct 18, 2025
31 checks passed
@github-actions github-actions bot mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants