Skip to content

fix(op-revm): add missing enveloped_tx validation in validate_env#3094

Merged
rakita merged 2 commits intobluealloy:mainfrom
sky-coderay:fix/validate-enveloped-tx
Oct 17, 2025
Merged

fix(op-revm): add missing enveloped_tx validation in validate_env#3094
rakita merged 2 commits intobluealloy:mainfrom
sky-coderay:fix/validate-enveloped-tx

Conversation

@sky-coderay
Copy link
Copy Markdown
Contributor

Fixes #3092

Non-deposit transactions need enveloped_tx set to calculate L1 costs properly.

Added validation in validate_env to catch this early instead of failing later during execution. Returns a clear
MissingEnvelopedTx error when the field is missing.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 13, 2025

CodSpeed Performance Report

Merging #3094 will not alter performance

Comparing sky-coderay:fix/validate-enveloped-tx (95aaaee) with main (10ff66d)

Summary

✅ 173 untouched

@sky-coderay sky-coderay force-pushed the fix/validate-enveloped-tx branch from 646a297 to 95aaaee Compare October 13, 2025 17:08
Copy link
Copy Markdown
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than panicking

@rakita rakita merged commit e9875b4 into bluealloy:main Oct 17, 2025
31 checks passed
@github-actions github-actions bot mentioned this pull request Oct 22, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 21, 2026
…uealloy/revm#3094)

* fix(op-revm): add missing enveloped_tx validation in validate_env

* cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return Error on missing envelope for OpTransaction

2 participants