Skip to content

chore: consolidate revme imports#3088

Merged
rakita merged 2 commits intomainfrom
rakita/remve-imports
Oct 17, 2025
Merged

chore: consolidate revme imports#3088
rakita merged 2 commits intomainfrom
rakita/remve-imports

Conversation

@rakita
Copy link
Copy Markdown
Member

@rakita rakita commented Oct 12, 2025 •
edited
Loading

Addded parse feature set so bytecode does not need to be included. Remove all single imports with one main import of revm inside revme.

No logical change

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #3088 will degrade performances by 33.12%

Comparing rakita/remve-imports (fd9d2df) with main (283d5a9)

Summary

❌ 21 regressions
✅ 152 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ CALL_50 96.2 µs 107.7 µs -10.73%
❌ CLZ_50 22.3 µs 23.1 µs -3.24%
❌ CREATE_50 408.3 µs 430.3 µs -5.11%
❌ DELEGATECALL_50 91.1 µs 99.4 µs -8.31%
❌ EXTCODECOPY_50 45.9 µs 51.7 µs -11.29%
❌ EXTCODEHASH_50 36.4 µs 41.4 µs -12.15%
❌ EXTCODESIZE_50 36.1 µs 41.1 µs -12.3%
❌ JUMP_50 17.4 µs 18 µs -3.28%
❌ RETURN_50 112.1 µs 122.6 µs -8.54%
❌ REVERT_50 113.2 µs 123.6 µs -8.35%
❌ SELFBALANCE_50 20.3 µs 24.8 µs -18.23%
❌ SLOAD_50 24 µs 32.6 µs -26.44%
❌ SSTORE_50 33.1 µs 49.5 µs -33.12%
❌ STATICCALL_50 94.8 µs 107 µs -11.4%
❌ analysis 43.3 µs 46 µs -5.87%
❌ burntpix 471.3 ms 487.7 ms -3.38%
❌ snailtracer 176.1 ms 192.6 ms -8.57%
❌ snailtracer-inspect 192 ms 208.5 ms -7.91%
❌ transact_1000tx_commit_inner_every_40 2 ms 2.8 ms -29.87%
❌ transact_commit_1000txs 2.7 ms 3.7 ms -27.17%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@rakita
Copy link
Copy Markdown
Member Author

rakita commented Oct 13, 2025

Performance is worse as hashmap flag is removed from revme. This is going to be a follow up PR where statetest-types gets included inside revm so they can share primitive features.

@rakita rakita merged commit 273ddf3 into main Oct 17, 2025
30 of 31 checks passed
@github-actions github-actions bot mentioned this pull request Oct 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klkvr klkvr klkvr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rakita @klkvr