feat: JournaledAccount, a nice way to update and track changes#3086
Merged
feat: JournaledAccount, a nice way to update and track changes#3086
Conversation
CodSpeed Performance ReportMerging #3086 will degrade performances by 4.28%Comparing Summary
Benchmarks breakdown
|
dd31b08 to
e2c6db0
Compare
44dd5a1 to
fc6878c
Compare
4 tasks
rakita
commented
Oct 13, 2025
rakita
commented
Oct 13, 2025
rakita
commented
Oct 13, 2025
zerosnacks
reviewed
Oct 13, 2025
Collaborator
zerosnacks
left a comment
There was a problem hiding this comment.
Proposed changes make sense to me, I believe the initial scope of changes in Foundry is limited to updating a number of function signatures to load_account_mut and I think there may be a few places where we can use the proposed JournaledAccount
Pending review from @klkvr
b55c3bb to
a77f029
Compare
a77f029 to
82eafb7
Compare
24a401d to
a9888f1
Compare
klkvr
approved these changes
Oct 22, 2025
Collaborator
klkvr
left a comment
There was a problem hiding this comment.
some naming nits but nothing critical so approving
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
…lloy/revm#3086) * JournaledAcccount * PoC: JournaledAccount, a nice way to update and track changes * cleanup * rm artifact * inline some of host fn * beneficiary refactor * nit * nits * fmt * rename and make old fn deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JournalTr
load_accountandload_account_codenow return & and not &mut of Account.Additional functions that return a journaled account with both Account and Journal (
load_account_mutandload_account_code_mut)This allows
account.set_balanceaccount.touch()without thinking if journal entry needs to be made