perf: pool Stack buffer allocations#2615
Closed
DaniPopes wants to merge 5 commits intobluealloy:mainfrom
Closed
Conversation
c16f42f to
964d821
Compare
CodSpeed Performance ReportMerging #2615 will improve performances by 19.49%Comparing Summary
Benchmarks breakdown
|
67aacc1 to
63d303f
Compare
63d303f to
22c8516
Compare
90d4406 to
e5e278d
Compare
Collaborator
Author
|
Subsumed by #2617 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete implementation, WIP code structure: pls advise @rakita
Ideally it would be
Pool<Stack>but importing Stack would be a dependency cycle, so we have to transmute the reference from Vec to StackEven more ideally Pool doesn-t exist and the Frame stack is re-used by clearing the frame and passing a &mut to initialize it, but this is very invasive...
edit: done here #2617