MB-65473: Extend VectorReader interface to get the EligibleDocumentSelector#66
Merged
abhinavdangeti merged 1 commit intomasterfrom Apr 1, 2025
Merged
MB-65473: Extend VectorReader interface to get the EligibleDocumentSelector#66abhinavdangeti merged 1 commit intomasterfrom
abhinavdangeti merged 1 commit intomasterfrom
Conversation
Member
CascadingRadium
commented
Mar 27, 2025
- Refactor interface as per MB-65473: Refactor and Optimize Pre-Filtered Vector Search bleve#2169 (comment)
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR refactors the vector index interfaces to extend the VectorReader interface with a new method for retrieving an EligibleDocumentSelector and updates the EligibleDocumentSelector interface accordingly.
- Added a NewEligibleDocumentSelector method in the VectorIndexReader interface.
- Revised the EligibleDocumentSelector interface to include an AddEligibleDocumentMatch method and updated its comments to reflect its filtering behavior.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vector_index.go | Added NewEligibleDocumentSelector and documented the selector functionality for KNN search. |
| index.go | Updated EligibleDocumentSelector documentation and added AddEligibleDocumentMatch. |
Thejas-bhat
approved these changes
Mar 27, 2025
abhinavdangeti
approved these changes
Apr 1, 2025
abhinavdangeti
added a commit
to blevesearch/bleve
that referenced
this pull request
Apr 2, 2025
- Refactor pre-filtered vector search to enhance performance and reduce
memory footprint.
- Replace the current bitmap-based approach for calculating segment
local document numbers with a more direct method, where the local
document numbers are mapped directly to the segment ID during the
execution of the eligible collector.
- Requires:
- blevesearch/bleve_index_api#63
- blevesearch/bleve_index_api#66
- blevesearch/zapx#317
- blevesearch/go-faiss#41
- blevesearch/faiss#49
---------
Co-authored-by: Abhinav Dangeti <abhinav@couchbase.com>
abhinavdangeti
added a commit
to blevesearch/sear
that referenced
this pull request
Apr 2, 2025
CascadingRadium
added a commit
that referenced
this pull request
Apr 7, 2025
…lector (#66) - Refactor interface as per blevesearch/bleve#2169 (comment)
CascadingRadium
added a commit
to blevesearch/bleve
that referenced
this pull request
Apr 7, 2025
- Refactor pre-filtered vector search to enhance performance and reduce
memory footprint.
- Replace the current bitmap-based approach for calculating segment
local document numbers with a more direct method, where the local
document numbers are mapped directly to the segment ID during the
execution of the eligible collector.
- Requires:
- blevesearch/bleve_index_api#63
- blevesearch/bleve_index_api#66
- blevesearch/zapx#317
- blevesearch/go-faiss#41
- blevesearch/faiss#49
---------
Co-authored-by: Abhinav Dangeti <abhinav@couchbase.com>
abhinavdangeti
added a commit
to blevesearch/sear
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.