MB-66112: fix an edge case related to index convergence#2200
Merged
Conversation
Thejas-bhat
commented
May 28, 2025
Member
- As an edge case, the segment layout can be such that the merge planning generates tasks having only a single non-empty segment.
- When this task is processed and introduced into the scorch system, the root doesn't change and you'd be stuck in an infinite loop because the same segment is still present in the system and the plan keeps generating the task with the same single segment, which doesn't converge the index to a steady state.
CascadingRadium
approved these changes
May 28, 2025
abhinavdangeti
approved these changes
May 28, 2025
CascadingRadium
pushed a commit
that referenced
this pull request
Aug 21, 2025
- As an edge case, the segment layout can be such that the merge planning generates tasks having only a single non-empty segment. - When this task is processed and introduced into the scorch system, the root doesn't change and you'd be stuck in an infinite loop because the same segment is still present in the system and the plan keeps generating the task with the same single segment, which doesn't converge the index to a steady state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.