Bug Fix: Validate KNN Filter Queries#2191
Merged
Merged
Conversation
CascadingRadium
commented
May 6, 2025
Member
- Previously, filter queries were not validated during the KNN request validation phase, which could lead to unexpected filter query behavior. This has been fixed by adding proper validation.
- Also fixed an issue where errors during JSON unmarshalling of invalid filter queries were being silently ignored.
- Previously, filter queries were not validated during the KNN request validation phase, which could lead to unexpected filter query behavior. This has been fixed by adding proper validation. - Also fixed an issue where errors during JSON unmarshalling of invalid filter queries were being silently ignored.
Likith101
approved these changes
May 6, 2025
abhinavdangeti
approved these changes
May 6, 2025
CascadingRadium
added a commit
that referenced
this pull request
Aug 21, 2025
- Previously, filter queries were not validated during the KNN request validation phase, which could lead to unexpected filter query behavior. This has been fixed by adding proper validation. - Also fixed an issue where errors during JSON unmarshalling of invalid filter queries were being silently ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.