MB-66163: fix checkpointing mechanism under sparse mutation scenarios #2186
Merged
Conversation
Member
|
@Thejas-bhat Let's backport this one as well to |
a452139 to
c18f28a
Compare
abhinavdangeti
approved these changes
Apr 24, 2025
metonymic-smokey
approved these changes
Apr 25, 2025
Thejas-bhat
added a commit
that referenced
this pull request
Apr 25, 2025
…#2186) - the checkpointing mechanism considers snapshots which fall within the `numSnapshotsToKeep * rollbackSamplingInterval` duration window. The snapshots outside this window are purged. - Under sparse mutation scenario for eg, when the workload pattern in such that it results in seldomly persisting snapshots that too outside this duration window - we could end up purging ALL those snapshots which makes the system fallback to preserving the latest snapshots - For a better partial rollback behaviour, we retain `rollbackRetentionFactor` worth of snapshots out of this duration window such that the cost of rebuilding the index from scratch is avoided. - This PR fixes the decision logic involved in the scenario pointed and tracks the previous checkpoints while opening back the index as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numSnapshotsToKeep * rollbackSamplingIntervalduration window. The snapshots outside this window are purged.rollbackRetentionFactorworth of snapshots out of this duration window such that the cost of rebuilding the index from scratch is avoided.