Enable saml signature verification by default#1227
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msenmurugan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick master |
|
@msenmurugan: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
requires changes. |
|
This needs to be there for 12.x, but not for 2020.2.x (since it will be enabled by default in the container itself) |
|
/hold |
| "DATA_RETENTION_IN_DAYS": "180", | ||
| "MAX_TOTAL_SOURCE_SIZE_MB": "4000", | ||
| } | ||
| if versionSAMLSignatureVersionSupportedByDefault, _ := util.IsVersionGreaterThanOrEqualTo(version, 2020, time.February, 0); versionSAMLSignatureVersionSupportedByDefault { |
There was a problem hiding this comment.
Only set it if it's exactly 2019.12.1. For future versions, this is set by default in containers.
|
/unhold |
|
/unhold |
|
/hold cancel |
* Enable saml signature verification by default for Black Ducl 2019.12.1
* Enable saml signature verification by default for Black Ducl 2019.12.1
resolves #1226