[BEEEP] - Sign and notarize CLI build binary#1051
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
=========================================
- Coverage 15.11% 6.79% -8.33%
=========================================
Files 67 67
Lines 2798 2798
Branches 483 483
=========================================
- Hits 423 190 -233
- Misses 2271 2576 +305
+ Partials 104 32 -72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (11)Checkmarx found the following issues in this Pull Request
|
|
Claude finished @BTreston's task in 1m 30s —— View job Code Review: PR #1051 - macOS CLI Build Signing
SummaryNo actionable findings. This PR adds macOS code signing and notarization steps to the CLI build workflow. The new steps correctly follow the same patterns already established by the existing The changes add:
No security, correctness, or maintainability concerns were identified. |
|
|
I've rolled this into the PR for PM-33578 |







🎟️ Tracking
📔 Objective
Adds access to secrets to sign the cli build binary for the macos-cli build step to resolve the error below:

The build artifact in https://github.com/bitwarden/directory-connector/actions/runs/23356740801/job/67949409099?pr=1052 has the now working binary.
📸 Screenshots