Use ElasticSearch 8.5.3 in Github Actions, remove Ubuntu 18#2707
Merged
Use ElasticSearch 8.5.3 in Github Actions, remove Ubuntu 18#2707
Conversation
acca49b to
396a714
Compare
Since ES version 8, cannot specify a type when using the Search API or the Count API.
since it tests almost nothing.
|
Kudos, SonarCloud Quality Gate passed! |
17 tasks
abitmore
added a commit
that referenced
this pull request
Jan 10, 2023
Fix Github Actions Ubuntu release build (Follow-up of PR #2707)
This was referenced Jul 3, 2023
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








For issues #2670 and #2706.
Note: BitShares Mekong 6.1 can work with ElasticSearch version 8 already, except that
xpack.security.http.ssl.enabled=false, andhistory_api::get_account_historyAPI doesn't work, andes_testunit tests will fail.This PR fixes the API and the test cases mentioned above.
key_not_found_exception: {"key":"count"}bitshares-core/tests/elasticsearch/main.cpp
Line 84 in bd440cf
Cause: cannot specify types in ES 8 (see Fix for ES7 : Specifying types is deprecated. #1997).
_docis used in theelasticsearch_plugin::get_account_history()function, which is used in an API and related unit tests. I think nobody is using it in production._docis used in theelasticsearch_plugin::get_operation_by_id()function, which is unused (added in elasticsearch history api #1682 #1725 with context)._docis used multiple times ines_test. Note that_docis needed for theGETAPI, but should not be used with theSEARCHAPI or theCOUNTAPI.Wildcard expressions or all indices are not allowedwhen trying to delete all indices for cleanup in unit tests.Cause: different default behavior between ES 7 and ES 8.