CMake and Windows Compilation#788
Closed
Jamezo97 wants to merge 2 commits intobitsandbytes-foundation:mainfrom
Closed
CMake and Windows Compilation#788Jamezo97 wants to merge 2 commits intobitsandbytes-foundation:mainfrom
Jamezo97 wants to merge 2 commits intobitsandbytes-foundation:mainfrom
Conversation
Merged
wkpark
pushed a commit
to wkpark/bitsandbytes
that referenced
this pull request
Nov 16, 2023
manually cherry-picked from PR bitsandbytes-foundation#788 and cleanup Signed-off-by: Won-Kyu Park <wkpark@gmail.com>
wkpark
pushed a commit
to wkpark/bitsandbytes
that referenced
this pull request
Nov 16, 2023
based on @Jamezo97 and @acpopescu work manually cherry-picked from PR bitsandbytes-foundation#788 and PR bitsandbytes-foundation#229 and cleanup by wkpark Signed-off-by: Won-Kyu Park <wkpark@gmail.com>
wkpark
pushed a commit
to wkpark/bitsandbytes
that referenced
this pull request
Dec 6, 2023
based on @Jamezo97 and @acpopescu work manually cherry-picked from PR bitsandbytes-foundation#788 and PR bitsandbytes-foundation#229 and cleanup by wkpark Signed-off-by: Won-Kyu Park <wkpark@gmail.com>
wkpark
pushed a commit
to wkpark/bitsandbytes
that referenced
this pull request
Dec 6, 2023
based on @Jamezo97 and @acpopescu work manually cherry-picked from PR bitsandbytes-foundation#788 and PR bitsandbytes-foundation#229 and cleanup by wkpark Signed-off-by: Won-Kyu Park <wkpark@gmail.com>
wkpark
pushed a commit
to wkpark/bitsandbytes
that referenced
this pull request
Dec 11, 2023
based on @Jamezo97 and @acpopescu work manually cherry-picked from PR bitsandbytes-foundation#788 and PR bitsandbytes-foundation#229 and cleanup by wkpark Signed-off-by: Won-Kyu Park <wkpark@gmail.com>
wkpark
pushed a commit
to wkpark/bitsandbytes
that referenced
this pull request
Dec 13, 2023
based on @Jamezo97 and @acpopescu work manually cherry-picked from PR bitsandbytes-foundation#788 and PR bitsandbytes-foundation#229 and cleanup by wkpark Signed-off-by: Won-Kyu Park <wkpark@gmail.com>
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
Collaborator
|
This is a very important contribution. Thank you for being so patient. We will work on this soon. |
Neumann-A
reviewed
Jan 9, 2024
|
|
||
| if(BUILD_CUDA) | ||
| target_compile_definitions(libbitsandbytes PUBLIC BUILD_CUDA) | ||
| target_link_libraries(libbitsandbytes PUBLIC cudart cublas cusparse) |
There was a problem hiding this comment.
you should be using https://cmake.org/cmake/help/latest/module/FindCUDAToolkit.html#module:FindCUDAToolkit and the targets associacted with it
green-s
pushed a commit
to green-s/bitsandbytes
that referenced
this pull request
Jan 18, 2024
based on @Jamezo97 and @acpopescu work manually cherry-picked from PR bitsandbytes-foundation#788 and PR bitsandbytes-foundation#229 and cleanup by wkpark Signed-off-by: Won-Kyu Park <wkpark@gmail.com>
wkpark
pushed a commit
to wkpark/bitsandbytes
that referenced
this pull request
Jan 29, 2024
based on @Jamezo97 and @acpopescu work manually cherry-picked from PR bitsandbytes-foundation#788 and PR bitsandbytes-foundation#229 and cleanup by wkpark Signed-off-by: Won-Kyu Park <wkpark@gmail.com>
Merged
wkpark
pushed a commit
to wkpark/bitsandbytes
that referenced
this pull request
Jan 31, 2024
based on @Jamezo97 and @acpopescu work manually cherry-picked from PR bitsandbytes-foundation#788 and PR bitsandbytes-foundation#229 and cleanup by wkpark Signed-off-by: Won-Kyu Park <wkpark@gmail.com>
wkpark
pushed a commit
to wkpark/bitsandbytes
that referenced
this pull request
Jan 31, 2024
based on @Jamezo97 and @acpopescu work manually cherry-picked from PR bitsandbytes-foundation#788 and PR bitsandbytes-foundation#229 and cleanup by wkpark Signed-off-by: Won-Kyu Park <wkpark@gmail.com>
Contributor
Author
|
Closing due to changes merged in #908 |
Contributor
|
thank you for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've attempted to setup a general CMakeLists.txt that will work cross platform, including on Windows.
To get things building on Windows some code changes were required.
IsCompletetemplate meta, the MSVC compiler gets pretty sad. I've switched it out with something that's technically equivalent given the current usage of the class.Hopefully this is useful.