Add an all_named ctor for filtering out catch-all flags#484
Merged
Conversation
swananan
added a commit
to swananan/aya
that referenced
this pull request
Jun 2, 2026
bitflags 2.12 adds Flags::all_named(), which shows up in clean CI public API output for VerifierLogLevel. bitflags/bitflags#484
tamird
pushed a commit
to aya-rs/aya
that referenced
this pull request
Jun 2, 2026
bitflags 2.12 adds Flags::all_named(), which shows up in clean CI public API output for VerifierLogLevel. bitflags/bitflags#484
MaximeWewer
pushed a commit
to MaximeWewer/aya
that referenced
this pull request
Jun 9, 2026
bitflags 2.12 adds Flags::all_named(), which shows up in clean CI public API output for VerifierLogLevel. bitflags/bitflags#484
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #443
This PR introduces a
Flags::all_namedconstructor that can filter out the catch-all_: !0flag used by external flags types. It's almost worth adding it as an inherentconstfunction to the target flags type too, but we can't do that without risking breakage unfortunately.