Skip to content

Fix beta test output#279

Merged
KodrAus merged 2 commits into
bitflags:mainfrom
KodrAus:fix/beta-test-output
Apr 20, 2022
Merged

Fix beta test output#279
KodrAus merged 2 commits into
bitflags:mainfrom
KodrAus:fix/beta-test-output

Conversation

@KodrAus

@KodrAus KodrAus commented Apr 20, 2022

Copy link
Copy Markdown
Member

cc @arturoc

It looks like I did go as far as making TRYBUILD=overwrite work for our custom .beta suffixes we use for these compiler output files 🙂 I stubbed out a CONTRIBUTING doc for us to collect any more of this trivia that comes up.

@arturoc

arturoc commented Apr 20, 2022

Copy link
Copy Markdown

great, thanks! I'll merge it into my PRs as soon as all the tests are passing

@arturoc

arturoc commented Apr 20, 2022

Copy link
Copy Markdown

Ah I think you need this #277 for the tests to pass. Somehow using derive serde::Serialize works in some versions but others require serde_derive::Serialize which works for all

@KodrAus KodrAus force-pushed the fix/beta-test-output branch from 64bc263 to 74abeb7 Compare April 20, 2022 11:02
@KodrAus KodrAus merged commit 66afe49 into bitflags:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants