Merged
Conversation
Cause Serialize and Deserialize derives are used from serde:: instead of serde_derive::
Member
|
Hmm, it looks like our tests have bit-rotted a bit here. If you run them locally with |
Author
|
I wasn't sure if I should do that. I'll send a different PR with the fix for the trybuild tests and merge it in these ones |
Member
|
I should write something up in the contributing docs for it 🙂 If you leave it to me I'll take care of it. I think we might do something special so the output is only checked in beta builds. |
Author
|
Yes that's what I was thinking. It's only in beta so not sure that running TRYBBUILD even using a beta version would overwrite the right files |
Merged
Member
|
Thanks @arturoc. I'll merge this one in and rebase my updates to the test output on top. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause Serialize and Deserialize derives are used from serde:: instead of serde_derive::