Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

fix(ci): clippy and ledger emulator#103

Closed
oleonardolima wants to merge 5 commits intobitcoindevkit:masterfrom
oleonardolima:fix/clippy-and-emulators-on-ci
Closed

fix(ci): clippy and ledger emulator#103
oleonardolima wants to merge 5 commits intobitcoindevkit:masterfrom
oleonardolima:fix/clippy-and-emulators-on-ci

Conversation

@oleonardolima
Copy link
Copy Markdown
Contributor

No description provided.

@oleonardolima
Copy link
Copy Markdown
Contributor Author

I got this to build with ubuntu 20.04 and rust 1.63 but with stable rust fails due to an error about requiring glibc 2.33. I think the stable rust version does work with ubuntu 22.04. I suspect some dependency is updated with stable rust and we need to pin that. Interestingly nightly rust works fine with 20.04 (in the doc example test). I think when I tried with ubuntu 22.04 rust 1.63 and nightly failed.

@notmandatory I was researching this and the failure started to happen on version 0.8.4 further, the IndexError: bytearray index out of range error seems consistent on all versions from 0.8.4 up to 0.9.1.

In the PR #103 I was playing with the versions, it was only failing due to the glibc error on 1.78 (stable), but it works on previous ones, and in the nightly as you've mentioned (1.80).

It's weird, because I've tried to reproduce the failure on stable locally and wasn't able to, and now it worked on the CI 😅

Maybe it's related to the runner machine being used at the moment CI is running ?

Originally from #101 (comment)

@oleonardolima oleonardolima force-pushed the fix/clippy-and-emulators-on-ci branch from fc69f03 to 983170b Compare June 4, 2024 00:02
@oleonardolima
Copy link
Copy Markdown
Contributor Author

closed in favor of #101

@oleonardolima oleonardolima deleted the fix/clippy-and-emulators-on-ci branch June 4, 2024 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants