Skip to content

feat: add way to make raw req and get url for BlockingClient#87

Merged
evanlinjin merged 2 commits intobitcoindevkit:masterfrom
evanlinjin:make-blocking-client-transparent
Jun 15, 2024
Merged

feat: add way to make raw req and get url for BlockingClient#87
evanlinjin merged 2 commits intobitcoindevkit:masterfrom
evanlinjin:make-blocking-client-transparent

Conversation

@evanlinjin
Copy link
Copy Markdown
Member

@evanlinjin evanlinjin commented Jun 15, 2024 •
edited
Loading

Also add method for getting from /tx/:txid endpoint.

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9525108942

Details

  • 8 of 11 (72.73%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 84.345%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/blocking.rs 8 11 72.73%
Totals Coverage Status
Change from base Build 9294320001: -0.2%
Covered Lines: 959
Relevant Lines: 1137
💛 - Coveralls

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9525267064

Details

  • 8 of 11 (72.73%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 84.345%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/blocking.rs 8 11 72.73%
Totals Coverage Status
Change from base Build 9294320001: -0.2%
Covered Lines: 959
Relevant Lines: 1137
💛 - Coveralls

notmandatory
notmandatory approved these changes Jun 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f3c0055

@evanlinjin evanlinjin force-pushed the make-blocking-client-transparent branch from f3c0055 to 3b778c5 Compare June 15, 2024 14:09
@evanlinjin evanlinjin requested a review from notmandatory June 15, 2024 14:10
evanlinjin
evanlinjin commented Jun 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member Author

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-ACK 3b778c5

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9528664736

Details

  • 74 of 79 (93.67%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.0%) to 87.531%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/async.rs 12 14 85.71%
src/blocking.rs 4 7 57.14%
Totals Coverage Status
Change from base Build 9294320001: 3.0%
Covered Lines: 1060
Relevant Lines: 1211
💛 - Coveralls

@evanlinjin evanlinjin merged commit bce24eb into bitcoindevkit:master Jun 15, 2024
oleonardolima
oleonardolima reviewed Jun 15, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-merge ACK 3b778c5
It just seems that it requires some dependency pinning for the MSRV

@notmandatory
Copy link
Copy Markdown
Member

notmandatory commented Jun 16, 2024

Oh ya CI is broken, same issue as on the BDK branch. I'll make a new PR to fix it.

@oleonardolima
Copy link
Copy Markdown
Collaborator

oleonardolima commented Jun 17, 2024

Oh ya CI is broken, same issue as on the BDK branch. I'll make a new PR to fix it.

Thanks! I didn't notice that it was the same problem as bitcoindevkit/bdk#1470

@ValuedMammal ValuedMammal mentioned this pull request Aug 28, 2024
Merged
3 tasks
chrono-raven6i90 added a commit to chrono-raven6i90/rust-esplora-client that referenced this pull request Oct 28, 2025
@chrono-raven6i90
Merge bitcoindevkit/rust-esplora-client#87: feat: add way to make raw…
1cda58f 
… req and get url for `BlockingClient`

3b778c57625ab8f4fb9b72b4e2013af74045a846 feat: add method for getting tx info via `GET /tx/:txid` (志宇)
bc3d431730052ace9766b328df2faae830c67062 feat: add way to make raw req and get url for `BlockingClient` (志宇)

Pull request description:

  Also add method for getting from `/tx/:txid` endpoint.

ACKs for top commit:
  evanlinjin:
    self-ACK 3b778c57625ab8f4fb9b72b4e2013af74045a846

Tree-SHA512: 81ab7af85b40fba0ec20194649d2f95b8e5fcd66c856ffb1d10ab9f81cddbfd11ef6ff399bd542e7b920a426ccbd9c114152ebd170bc8e6b3562b44e16ce612d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleonardolima oleonardolima oleonardolima left review comments

@notmandatory notmandatory Awaiting requested review from notmandatory

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evanlinjin @coveralls @notmandatory @oleonardolima