fix(blocking): get_with_retry is private method#100
Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom Sep 26, 2024
Merged
fix(blocking): get_with_retry is private method#100ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
get_with_retry is private method#100ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
Conversation
Pull Request Test Coverage Report for Build 11034104409Details
💛 - Coveralls |
chrono-raven6i90
added a commit
to chrono-raven6i90/rust-esplora-client
that referenced
this pull request
Oct 28, 2025
…_retry` is private method
bfaa9ae546e4087c1a81c653333ee9b1c949e0ce fix(blocking): `get_with_retry` is private method (valued mammal)
Pull request description:
Clean up after #98 which accidentally exposed `get_with_retry` publicly for the blocking client.
ACKs for top commit:
oleonardolima:
ACK bfaa9ae546e4087c1a81c653333ee9b1c949e0ce
Tree-SHA512: 33abd34e919e27069107947c34915b9de3547ab1d78291841f2052552abd23fd59621ee6ae3ed9bd8e3eda608c2e5b9285529df1dcba8a4a1705ca1f1491c136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up after #98 which accidentally exposed
get_with_retrypublicly for the blocking client.